DanielLeens commented on PR #13008: URL: https://github.com/apache/seatunnel/pull/13008#issuecomment-6758164157
Pushed `d284cb5aa8` (the three open items from the 2026-11-03 self-review) plus a fresh merge of `dev` (`21a5e412b2`, no conflicts, 0 behind), and marked the PR ready for review. - **Issue 5 (access control note)**: `docs/en|zh/engines/zeta/web-ui.md` now state, next to the capability summary, that the state-changing controls call the same REST endpoints as the CLI and are protected only by the node's REST authentication, that the packaged `config/seatunnel.yaml` enables HTTP without authentication, and that `enable-basic-auth` / HTTPS should be enabled per [Security](https://github.com/apache/seatunnel/blob/dev/docs/en/engines/zeta/security.md) before exposing the UI. Server-side CSRF hardening is left for a separate issue, as suggested. - **Issue 6 (block survives Clear Tags)**: `managers/index.tsx` resets `tagEditBlocked` and the line cache in the Clear success branch. The unrepresentable-tags test now continues with Clear, types a new tag, asserts Update is enabled again and that `{ zone: 'prod' }` is sent. - **Issue 7 (stale audit comment)**: `UpdateTagsService` no longer copies the previous map; it reads the previous size and the comment says counts are logged on purpose because tag content is operator input. `summarizeTagsForAudit` and its test are unchanged. CI: fork Build for this head is running at https://github.com/DanielLeens/seatunnel/actions/runs/42749739366 ; the previous head `69eb336df1` was green (run 41566050818). Local validation was scoped Spotless, Prettier and `git diff --check` only. F8 screenshots remain the agreed separate docs PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
