goutamadwant opened a new pull request, #13247:
URL: https://github.com/apache/seatunnel/pull/13247

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code 
changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
     - Make sure that the pull request corresponds to a [GITHUB 
issue](https://github.com/apache/seatunnel/issues).
     - Name the pull request in the form "[Feature] [component] Title of the 
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix 
typo in README.md doc`.
   -->
   
   ### Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull 
request adds checkstyle plugin.-->
   
   Fix Apache SeaTunnel E2E false leak reports for native G1 refinement workers.
   
   Fixes #13246.
   
   Completed Java 17 jobs could fail the 120-second cleanup check when G1 
started a native worker after the initial thread snapshot. Add a precompiled, 
full-name `G1 Refine#[0-9]+` match to the existing system-thread classifier and 
extend its existing regression class. Both filtering paths use that classifier.
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   <!--
   Note that it means *any* user-facing change including all aspects such as 
the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description and/or an example to show the 
behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to 
the released SeaTunnel versions or within the unreleased branches such as dev.
   If no, write 'No'.
   If you are adding/modifying connector documents, please follow our new 
specifications: https://github.com/apache/seatunnel/issues/4544.
   -->
   
   
   No production user-facing change. Test behavior changes from rejecting 
native G1 workers to recognizing their exact numeric names. Near-name 
application workers remain checked. The timeout, classloader checks and 
container lifecycle are unchanged.
   
   The detector remains name based, so an application using an identical 
native-worker name would also be exempt. Other native thread families are 
outside this patch.
   
   ### How was this patch tested?
   
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   If you are adding E2E test cases, maybe refer to 
https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf,
 here is a good example.
   -->
   
   
   - Causal baseline on Java 17: the extended 37-case regression class fails 
exactly the 3 new native-name cases, with zero errors/skips.
   - Candidate: all 37 cases pass on Java 11 and 17, including 10 negative near 
names. Maven 3.9.16 was used.
   - Scoped formatting and verification passed.
   - Combined with the separately scoped Python image-preparation patch, actual 
Java 17 Zeta source (3/3) and transform (4/4) suites passed through a 
standalone JUnit Platform launcher. These are not Maven Failsafe results. Java 
17 image/mount substitutions were validation only and are absent from this PR.
   - Native ownership is confirmed by the [OpenJDK 
constructor](https://github.com/openjdk/jdk17u/blob/14a8c6288c963d6d61f12227375398d8abafc709/src/hotspot/share/gc/g1/g1ConcurrentRefineThread.cpp#L36).
 No Java 11 runtime failure is claimed. Hosted CI remains pending.
   
   To run the regression class after building its dependencies:
   
   ```sh
   mvn -B -pl seatunnel-e2e/seatunnel-e2e-common 
-Dtest=SeaTunnelContainerThreadExemptionTest -DskipIT=true test
   ```
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR.
   * [ ] If you are contributing the connector code, please check that the 
following files are updated:
     1. Update 
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
 and add new connector information in it
     2. Update the pom file of 
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in 
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in 
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector 
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
   
   Checklist applicability: no new JARs, connector registration, user 
documentation or incompatible changes are introduced.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to