SEZ9 commented on PR #11512:
URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-6817193654

   Thanks @goutamadwant for the clear answer on F7. If both 
`CdcEnumeratorProgressReport` constructors in `9170d5e78a` document that 
present counts must be non-negative and that assigned = completed + running is 
enforced only when all three are `EXACT`, that is the invariant I was looking 
for; I'll confirm it against the diff rather than take it as closed here. Noted 
that `122d0af5fa` only adds the `SnapshotSplitAssignerTest` ordering fix and 
that `docs/*/developer/cdc-progress.md` is unchanged since `d2f8193c97`.
   
   Now that the API types and `docs/en/developer/cdc-progress.md` have moved to 
the API-only PR, could you point me to where the remaining items from my 
earlier review land, so nothing falls between the two PRs?
   
   - F2 (no credentials/secrets in connector-native position payloads) and F4 
(runtime-collection docs describing pull/derive vs. the registration-based 
enumerator report path) — handled in the doc in the API-only PR, or still open?
   - F5 (which connectors implement the provider) — if this is intentionally 
out of scope for now, a short known-gap note in the doc would help readers.
   - F6 (`CdcProgressLifecycle.SNAPSHOT` Javadoc vs. the ownership rule in the 
doc) — with `COMPLETED` added to the lifecycle, does the `SNAPSHOT` Javadoc now 
match?
   - F1 (unbounded `activeSplits` vs. the documented bounded contract) and F8 
(shallow copy / element immutability of `CdcSnapshotSplitProgress`) — are these 
addressed in the API-only PR, or should I expect them in this engine slice?
   - F3 (encode the new enums by name, not ordinal, in the engine codec) — this 
stays with the engine slice here; a pointer to the codec change, or a note that 
it is deferred, is all I need.
   
   With those pointers I'll re-check against the current diffs of both PRs.
   
   <!-- streview-comment:2285 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to