SEZ9 commented on issue #13232: URL: https://github.com/apache/seatunnel/issues/13232#issuecomment-6819807811
Thanks for the well-scoped proposal, and thanks @goutamadwant for picking it up in #13238. Two things worth confirming as part of the change: - Every production path that constructs `MultiTableSink` should go through `FactoryUtil.createMultiTableSink()` (and therefore `ConfigValidator`). If any path builds the sink directly, removing the constructor check would silently drop the guard. - When moving the boundary tests to the factory entry, please account for the factory's exception wrapping so the assertions still verify that the diagnostics name `multi_table_sink_replica` and the rejected value (`0`, `-1`). I'll follow up with review comments on #13238. <!-- streview-comment:2299 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
