SEZ9 commented on issue #12707:
URL: https://github.com/apache/seatunnel/issues/12707#issuecomment-6841718716

   @karthik-0306 yes, that scope sounds right, and the order is fine: the next 
slice should be exactly (1) a per-user, per-version cache directory outside 
`site-packages` and (2) deterministic version → distribution URL construction, 
with no network download yet. That matches step 1 of the order you proposed, so 
no need to reshuffle.
   
   Two things to keep in mind for that PR:
   
   - Keep it strictly to those two pieces. Streamed download, extraction, 
checksum/signature verification, `plugin_config` rewriting, local-mode run, and 
anything PyPI/console-script related stay out and come in their own follow-ups, 
as in your list.
   - Keep the ownership boundary explicit, as you did in the current PR: the 
cache directory is the only location later helpers are allowed to modify, never 
a source checkout or a shared installation. Please state that in the module 
docstring of the new code too.
   
   On the gate: please do hold off opening it until the current PR is actually 
merged, as you already offered. Preparing the branch locally in the meantime is 
of course fine.
   
   For the URL builder, the release layout you confirmed (the versioned 
`-bin.tar.gz` plus `.sha512` / `.asc`, and `seatunnel/KEYS`) is the right 
basis. Please include focused tests for version-to-URL resolution and for 
cache-path isolation (different users / different versions never share a 
directory), and link the new PR here once it is open so it can be reviewed on 
its own.
   
   I'll answer your three open questions (gpg CLI vs. dependency, 
`SEATUNNEL_DIST_REPOSITORY`, 3.0.0 as first target) before you reach the steps 
that need them; none of them block this slice.
   
   <!-- streview-comment:2305 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to