SEZ9 commented on PR #13235:
URL: https://github.com/apache/seatunnel/pull/13235#issuecomment-6843232111

   Thanks @SEPURI-SAI-KRISHNA for the detailed review. I agree with the 
assessment: the rule itself and dropping the constructor check look right, and 
since every production path goes through `FactoryUtil.createMultiTableSink`, 
moving the validation there does not lose coverage.
   
   A few concrete asks for the author before this can move forward:
   
   1. **CI.** As noted above, the `Build` workflow (`build_main.yml`) runs on 
push in the fork, and there are no workflow runs there yet. Please enable 
Actions in your fork and push again (or trigger `Build` manually on this 
branch) so we get a run to look at. The pending `PR signal` run also needs 
approval from a committer.
   
   2. **Rejected value in the diagnostic.** This is the blocking point for me. 
The linked issue lists "Keep diagnostics identifying the option and invalid 
value" in its acceptance criteria, and with only the rule added, the cause 
message produced via `OptionUtil` `ERROR_TEMPLATE` / 
`Condition.conditionToString` prints the key, operator and bound but not the 
configured value, while the outer `FactoryException` is the generic "Unable to 
create a sink for identifier 'MultiTableSink'." Please make sure a user who 
sets `0` or `-1` for `multi_table_sink_replica` actually sees that value in the 
error (e.g. a more specific message when the rule fails, or wrapping with the 
configured value), and restore a test assertion on the value so this does not 
silently regress again.
   
   3. **Constructor comment.** The issue asks to remove the constructor 
comment; this PR rewrites it instead and adds a similar one in 
`MultiTableSinkFactory.optionRule()`. Please drop both; the rule is 
self-explanatory.
   
   Once those are addressed and CI is green, I'm happy to do another pass.
   
   <!-- streview-comment:2318 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to