sharpca commented on PR #13219:
URL: https://github.com/apache/seatunnel/pull/13219#issuecomment-6847742353
Hi @DanielLeens, thanks for the approval, and especially for cross-checking
the real job durations in the fork runs.
I took your optional nit: the comment now reads "around 95-100 minutes on
ubuntu-latest and goes over 120 minutes on slower runners", and I applied the
same wording to the PR description. The budget itself stays at 210 minutes, and
the fork `Build` on the new head `bab20ab82` is green.
Two things about the state of play:
- The duplicate locale PR #13187 has been closed by its author without
merging, so the locale fix now has a single owner. That is the convergence you
suggested — thank you for nudging it.
- All four of my locale/CI PRs are green and mergeable now, and the
apache-side `PR signal` check has passed on each of them:
| PR | head |
| --- | --- |
| #13170 (locale) | `7235d6a32` |
| #13219 (CI budget) | `bab20ab82` |
| #13081 (CLI enum) | `cac71da1e` |
| #13083 (JDBC dialect) | `b3209869b` |
The only remaining step on each of them is a maintainer action to merge.
One small detail on this PR: because I pushed the comment-only fix after
your review, the `Label-when-reviewed` workflow run that your review triggered
([43004577467](https://github.com/apache/seatunnel/actions/runs/43004577467))
is still waiting for approval, so the `reviewed` label has not landed here yet.
Approving that workflow run would put this PR on the same footing as the other
three.
Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]