SEPURI-SAI-KRISHNA commented on issue #13223:
URL: https://github.com/apache/seatunnel/issues/13223#issuecomment-6848249307

   @SEZ9 Thanks. On the three rows:
   
   - **Iceberg**: up as #13268, a draft until #13243 merges; only its two 
`[Iceberg]` commits belong there. Delta writers are `KEYED` on the first key 
column of the row. The append writers (`UnpartitionedWriter`, 
`PartitionedAppendWriter`) append every record as a data row whatever its row 
kind; only the delta writers read `RowKind`, so there is no delete path and no 
order between changes to keep. Measured: the keyed CDC input (1000 keys, 3500 
insert, update and delete rows) into a table without a key gives the same 3500 
rows with replica 1 and 4. So they are `RANDOM`, and the PR says why. It has 
`IcebergSinkCDCIT` back at replica 2 and a repeated changes case at replica 4, 
which fails with random routing (139 rows instead of 50). If #12881 merges 
first, I rebase on it before marking it ready.
   - **JDBC XA**: agreed, it stays `UNSUPPORTED` until #13242 and #13109 land, 
and the same-layout restore test at replica 2 will be part of that PR.
   - **JDBC UNIQUE gap (#13250)**: the routing key is the `primary_keys` value 
in every case. When `primary_keys` is configured, `JdbcSinkFactory` replaces 
the primary key of the table with it; otherwise it sets `primary_keys` from the 
primary key, or from the UNIQUE key when there is none. I added a test where 
the configured `primary_keys` differ from the primary key of the table. The 
negative case (no key: rejected above 1 replica, works with 1) is the rejection 
#13243 adds, covered there by `testKeyedWriterNeedsAValidKey` and 
`testOneReplicaAcceptsEveryModeWithoutAKey`; the JDBC E2E on top of #13242 will 
include it.
   
   I cannot edit the table in the issue body, so I will post each PR here as it 
opens.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to