DanielLeens commented on issue #13273:
URL: https://github.com/apache/seatunnel/issues/13273#issuecomment-6852500116

   Thanks for the detailed report and the minimized operating context. I 
checked current `dev` (`dcf97867ac13c04661a35af8568f2e3e40d07ef1`): 
`/running-jobs/summary` does use `JobInfoService.decodeJobBasicInfo`, which 
reads directly from the `Data` bytes, and `JobImmutableInformation.writeData` 
begins with `jobId`, `jobName`, the savepoint flag, and `createTime`. The 
current fast path assumes a fixed preceding serialization layout, has no 
semantic validation of the decoded values, and only falls back when the read 
throws. A successful but misaligned `readString()` can therefore publish an 
invalid job name and create time instead of reaching the compatibility fallback.
   
   This is a real Zeta REST-summary correctness and response-size issue. I also 
searched the open PRs and found no existing change for `decodeJobBasicInfo`, so 
a focused fix is welcome. Please keep it limited to the summary decoder; it 
should not change the full `/running-jobs` response, job state, or the 
persisted `JobImmutableInformation` format.
   
   For a PR, please:
   
   1. Decode the real `SerializationService.toData(JobImmutableInformation)` 
representation with the same header/version semantics used by the normal 
serializer. Please do not rely only on an unconditional one-byte skip: the test 
should prove the fast-path result equals normal `toObject(...)` deserialization 
for both `jobName` and `createTime`.
   2. Add a regression that reaches the current false-success path (large 
enough serialized information and a job-id/layout that makes the bogus string 
length readable), then assert that `/running-jobs/summary` returns the real, 
bounded name and timestamp rather than raw payload bytes.
   3. Retain the existing legacy/fallback coverage in 
`JobInfoServiceNullSafetyTest`, so older readable data still takes the safe 
path if fast decoding is incompatible.
   4. Include the before/after summary size or a deterministic equivalent in 
the PR description, with no credentials or production endpoint details.
   
   If you do not plan to submit the PR, a small sanitized serialized-data 
fixture that demonstrates the false-success case would let another contributor 
reproduce the exact boundary safely. No labels or assignments were changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to