chovy-3012 commented on PR #13257:
URL: https://github.com/apache/seatunnel/pull/13257#issuecomment-6860122933

   Thanks @DanielLeens for the review! Both issues are addressed in 93c626f17f.
   
   **Issue 1 — migration and legacy-split identity policy**
   
   Added matching entries to `docs/en` and `docs/zh` 
`introduction/concepts/incompatible-changes.md`: they identify the affected 
jobs (single-table sources explicitly setting `case_sensitive = false`), state 
that `true`/the default preserves the historical spelling, and give the restore 
policy — restart from a new checkpoint instead of reusing an old one, because 
saved splits are not rewritten. The focused regression is 
`testRestoredMixedCaseSplitFailsFastAgainstLowercaseTableMap` in 
`DorisTableConfigTest`: a legacy `TestDB.TestTable` split is restored into a 
`testdb.testtable`-keyed table map, and the reader is asserted to fail fast 
with `SHOULD_NEVER_HAPPEN` rather than read another table or rewrite the split 
identity.
   
   **Issue 2 — source entry path integration coverage**
   
   Added `testDorisCaseInsensitive` to the existing `DorisIT`, with 
`doris_source_and_sink_case_insensitive.conf` naming the fixture table in mixed 
case (`E2E_SOURCE.DORIS_E2E_UNIQUE_TABLE`, created lowercase by the IT) under 
`case_sensitive = false`. It runs the full factory → catalog → split → reader 
path, and `checkSinkData` asserts the exact rows read from the resolved 
lowercase table. The existing true/default and `table_list` coverage is 
unchanged.
   
   **Turkish-default-locale unit case (non-blocking)**
   
   Added `testSingleTableCaseInsensitiveLowercasesWithTurkishDefaultLocale`: 
the default locale is set to `tr-TR` around a single-table `false` config and 
restored in a `finally` block. The identifiers start with a capital `I`, so a 
locale-sensitive `toLowerCase()` regression would produce a dotless `ı` and 
fail the assertion.
   
   Two small hardenings from self-review: the Turkish test data uses names 
starting with a capital `I` (`InventoryDB.InventoryTable`) so the case actually 
discriminates, and the quoted reader failure message in the migration docs now 
matches the full text in `DorisSourceReader`.
   
   165/165 connector-doris unit tests pass and spotless is clean on both 
modules; the new IT runs in the doris-connector-it CI job.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to