SEZ9 commented on PR #11493:
URL: https://github.com/apache/seatunnel/pull/11493#issuecomment-6870693525

   Thanks for the follow-up commits on `b3aa0f2f`. Checking them against the 
four points from my earlier review:
   
   **F1 – silent STRING → JSON change for Snowflake VARIANT / Doris JSON/JSONB 
/ StarRocks JSON.** The `handle_json_as_string` source option is exactly the 
opt-out I was asking for, so the design concern is resolved. Remaining ask: 
please make sure `docs/en/introduction/concepts/incompatible-changes.md` (and 
the zh counterpart) explicitly states that these three connectors now emit 
`JSON` by default and names `handle_json_as_string` as the way to restore the 
previous `STRING` behavior, so users hitting this on upgrade can find the 
escape hatch quickly.
   
   **F2 – JSON is physically a plain String, so non-JSON text can reach a 
native JSON sink.** The Doris change helps here: running every row through 
`jsonSchema.convert(row)` before re-emitting the JSON field as a string token 
means malformed documents are rejected on the Doris side as well, not only at 
the StarRocks load boundary. Please add a unit test in the Doris serializer 
test that feeds an invalid JSON string into a `SqlType.JSON` field and asserts 
the failure, so this validation doesn't regress. For `schema-feature.md`, a 
one-line note that `json` is String-backed and validated only by sinks that 
write native JSON would set the right expectation.
   
   **F3 – StarRocks native JSON columns + default CSV Stream Load format fails 
only at load time.** I don't see this addressed in the new commits. The ask 
stands: fail fast at sink initialization when a `JSON` field is present and the 
load format is CSV, with a clear message pointing to the JSON format, and 
document that constraint in `docs/en/connectors/sink/StarRocks.md`.
   
   **F4 – Snowflake sink with a user-defined query skips `PARSE_JSON` 
wrapping.** Also not addressed yet. Either wrap JSON fields in the user query 
path too, or reject/warn at initialization when a `JSON` field is present with 
a custom query, and state the behavior in 
`docs/en/connectors/sink/Snowflake.md`.
   
   Separately, the head now reports merge conflicts with `dev` (ahead 20 / 
behind 36). Please sync `dev`, resolve the conflicts keeping both sides intact, 
and push a fresh head; the open TextFormatSchemaTest failure and the Doris 
integration validation noted above should be re-verified on that head rather 
than on `b3aa0f2f`.
   
   Once F3 and F4 have fail-fast handling plus docs, and the branch is 
conflict-free, I'm happy to take another full pass.
   
   <!-- streview-comment:2337 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to