SEZ9 commented on issue #13254:
URL: https://github.com/apache/seatunnel/issues/13254#issuecomment-6870100693

   Thanks @chovy-3012, that clears up both questions.
   
   Confirming the behaviour on current `dev` (3.1.0-SNAPSHOT) is helpful, and 
your reading of `DorisTableConfig#of` matches the earlier description: the 
lowercase conversion is applied to an intermediate `DorisTableConfig` built 
from the `database`/`table` options, while the returned config is assembled 
separately from the raw option values, so the converted object is discarded and 
`case_sensitive=false` has no effect in single-table mode. Since the 
single-table source was already intended to support `case_sensitive`, I agree 
this is a bug in the original code rather than a missing feature, so let's 
treat it as a bug fix.
   
   The fix should be to apply the lowercase conversion to the config that is 
actually returned (or return the converted object) so single-table and 
multi-table modes behave consistently. Would you like to open a PR for this? If 
not, let me know and I can pick it up.
   
   <!-- streview-comment:2329 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to