SEZ9 commented on PR #11856:
URL: https://github.com/apache/seatunnel/pull/11856#issuecomment-6870898385

   Quick status update on this PR.
   
   The head `b32e5360d881cc9cdf889a9a44370767129babf3` is now reported as 
having merge conflicts with `dev` (`mergeable_state=dirty`), so the earlier 
note in review 5821101205 that it merged cleanly no longer holds. Please rebase 
onto the latest `dev` and resolve the conflicts, keeping both the intended 
graceful-shutdown change and the upstream changes intact. Since this will 
produce a new head, I'll re-check the resolved version in full rather than 
diffing against the old one.
   
   Independently of the conflict, the points from the previous review are still 
open and nothing in the thread so far addresses them:
   
   - **PR11856-F1 (HIGH):** publishing the graceful-shutdown marker from 
`ManagedService.shutdown()` in `SeaTunnelServer` happens when the Hazelcast 
node is already PASSIVE, so the IMap write can be rejected and the WARN 
downgrade silently no-ops in real graceful shutdowns. This one is the key fix — 
please move the marker publish to a point where the node can still write, and 
ideally add a test that exercises a real graceful shutdown path.
   - **PR11856-F2 / F4:** the marker is destructively consumed before 
task-failure processing (losing the classification on master failover 
mid-processing) and entries in `engine_gracefulMemberRemoval` have no eviction, 
relying on a manual TTL check across node clocks. Please consider a 
non-destructive read plus a proper IMap TTL/eviction config.
   - **PR11856-F3 / F6:** the graceful path swaps the `JobException` in 
`TaskExecutionState` for a plain String, which changes the persisted/REST error 
payload and contradicts the "state handling unchanged" claim. Please keep the 
throwable and only adjust the log level.
   - **PR11856-F5 / F8:** classification by matching the free-text message in 
`PhysicalVertex` (with the template duplicated as a format string in 
`CoordinatorService` and a regex in `PhysicalVertex`) is fragile and spoofable. 
A typed signal (dedicated exception type or flag) would remove both the drift 
risk and the mimicry concern.
   - **PR11856-F7:** please add a short docs/ section describing the new marker 
IMap and the WARN downgrade behavior.
   
   Once the rebase is pushed, a short note on which of the above are addressed 
in the new head would help speed up the re-review. Thanks for working through 
this!
   
   <!-- streview-comment:2339 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to