davidzollo commented on PR #12014:
URL: https://github.com/apache/seatunnel/pull/12014#issuecomment-6886090867

   ### Implementation Notes and Trade-offs
   
   Head: `3ee352173a6dd251b700eb1112a0cd59c11687c8`
   
   This update follows up on the Apache SeaTunnel PR for opt-in MySQL CDC 
TRUNCATE events with Zeta and a JDBC sink (#8259). It resolves the factory and 
parser test conflicts with `dev`: the existing startup-mode guards remain 
alongside the PR's table-operation options, and both the SET/ENUM and TRUNCATE 
parser cases remain.
   
   The English and Chinese docs now distinguish submission from the failure 
that occurs only when an unsupported engine receives a table-operation event, 
use the JDBC key `is_exactly_once`, and link the filters to the table-operation 
section. Adding a new cross-connector submission validator would expand this 
repair beyond the existing contract.
   
   The MySQL E2E uses an empty foreign-key reference to make a real sink 
TRUNCATE fail without blocking prior inserts. It checks that committed rows 
survive, removes the fault, restores from the failed job's completed 
checkpoint, and checks that only the post-TRUNCATE row remains. Cleanup stops 
any still-active test job without discarding the failed job's checkpoint. This 
covers the keyed sink's final state; it does not assert intermediate duplicate 
visibility for append-only targets.
   
   Scoped Spotless and the staged diff whitespace check passed. The updated 
Build still needs to run the MySQL CDC and JDBC E2E suites.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to