davidzollo commented on PR #12510:
URL: https://github.com/apache/seatunnel/pull/12510#issuecomment-6886048956

   Implementation Notes and Trade-offs
   
   Head: `d1d3c48f23edd887e1dede6b8b231991edc924a4`
   
   I synced this Apache SeaTunnel PR with `dev` while preserving its five-file 
recovery patch. The prior Java 8 engine integration failure was specific: the 
worker was lost during cancellation, and the pipeline changed from `CANCELING` 
to `FAILING` to `FAILED` even though the test expected `CANCELED`. The old 
branch did not contain #12377. The sync brings in #12377’s cancellation 
precedence while retaining this PR’s resource-allocation and master-failover 
handling.
   
   I used a normal merge to retain the contributor’s history and both sets of 
regression assertions. Reimplementing #12377 here would duplicate the 
correction already in `dev`; changing the failing assertion would hide the 
cancellation regression. The final patch relative to `dev` has the same stable 
patch ID as the original PR and contains no dependency changes.
   
   Scoped Spotless ran in the engine server and engine E2E modules, and the 
final diff check passed. Runtime verification remains with the GitHub Build on 
this head, including the Java 8 cancellation test and the existing restore 
coverage.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to