DanielLeens opened a new pull request, #13287:
URL: https://github.com/apache/seatunnel/pull/13287

   Yes, I am contributing to Apache SeaTunnel.
   
   ## Summary
   
   Add an explicit `GoldenDB` JDBC dialect option for Source and Sink, reusing 
the existing MySQL-compatible dialect and catalog. Existing GoldenDB URLs 
without a dialect continue to select the generic dialect, and existing MySQL 
URL selection remains unchanged.
   
   Document both the GoldenDB-driver and MySQL-protocol configurations in 
English and Chinese. No new driver dependency or connector module is added.
   
   ## Implementation notes and trade-offs
   
   The new factory is selected only when `dialect = "GoldenDB"` is configured. 
Automatically selecting it for `jdbc:goldendb:` URLs would change the behavior 
of existing jobs, including their catalog and authentication paths. The MySQL 
catalog requires `username` and `password` and does not forward the JDBC 
`properties` map to catalog connections.
   
   This approach assumes that the target GoldenDB server and driver support the 
MySQL dialect and catalog operations used by the job. That assumption has not 
been verified against a GoldenDB instance; driver-specific metadata, SQL, 
types, and transaction behavior require real-environment validation.
   
   ## Validation
   
   - `./mvnw spotless:apply -pl 
seatunnel-connectors-v2/connector-jdbc,seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1
 -nsu -Dmaven.gitcommitid.skip=true -T 3C` passed.
   - Added dialect-selection compatibility coverage and a JDBC Source-to-Sink 
integration scenario using a MySQL server and explicit GoldenDB dialect. GitHub 
CI results are pending.
   - No local compilation, unit tests, integration tests, or Docker runs were 
performed. No GoldenDB server or driver was available for validation. The MySQL 
integration scenario does not establish compatibility with a GoldenDB server.
   
   ## Issue
   
   No associated issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to