SEZ9 commented on PR #12209: URL: https://github.com/apache/seatunnel/pull/12209#issuecomment-6935959209
@88fantasy thanks for the follow-up. My own review on this PR is already an approval: on head `2e236b4b`, Build run 43186818685 completed successfully, and I have no remaining source blocker. I'm not asking for any further code change on this head. The earlier Changes requested is not mine to clear. It belongs to the reviewer you addressed, and only that reviewer or a write-capable maintainer can refresh or dismiss it. I have read permission only, so my approval does not replace that step or the merge action. Non-blocking, to be tracked after merge: - **Heartbeat throttle:** the throttle timestamp is advanced before delivery is known to succeed, so a dropped or failed heartbeat can silence the run for a full `openlineage_heartbeat_min_interval_ms`. - **Typed configuration:** the cluster `auth_token` is stored as plain text in a raw `Map<String,Object>` on `EngineConfig`, with no typed holder that masks it in `toString()`/`equals()`. If it is convenient, a follow-up issue linked here for these two would help keep them from getting lost. <!-- streview-comment:2387 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
