SEZ9 commented on PR #12051: URL: https://github.com/apache/seatunnel/pull/12051#issuecomment-6943200589
Thanks for the update in `022e216e6`, @CryoThrust. Constructing the fixtures as non-master and switching to master just before explicit activation sounds like the right approach for the constructor window from Issue 1; I'll confirm against the diff. Thanks also for catching the same window in `testCheckNewActiveMasterIsIdempotentWhenAlreadyActive`, and for updating the title and description to separate this follow-up from the scheduler termination fix that was already merged. Your comment doesn't mention a few of the earlier points, so could you confirm where each stands in `022e216e6`? 1. **Assertion in the shared cleanup helper:** the executor-alive check could mask the real test failure or break unrelated callers. Can it still fire for any caller of the helper after the fixture changes? 2. **Unintended NPE or reflection failure:** if the coordinator service was already cleared, the executor lookup could throw one of these instead of the intended diagnostic. Is that case guarded? 3. **Ordering contract:** is "stop schedulers before mutating `isActive`" enforced by the code, or is it still documented only in the comment? The earlier points about the termination helper and the 5-second `awaitTermination` budget appear to concern logic that, as noted in the review of `4416fe983`, had already landed in `dev`, so I don't expect changes for them in this PR. Nothing is needed on the security point either, since the change is confined to test fixture cleanup. Thanks for sharing the local JDK 11 run (37 tests, zero failures/errors, two skips). As you noted, the updated head still needs its GitHub Build result, so please post here once that is in. <!-- streview-comment:2402 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
