SEZ9 commented on issue #13290:
URL: https://github.com/apache/seatunnel/issues/13290#issuecomment-6962326449

   Thanks for the clear write-up, and thanks @CryoThrust for picking this up so 
quickly.
   
   The points I would have asked about are already covered in your comment: the 
common and MaxCompute implementations are identical apart from their package, 
the ClickHouse-local parser has no connector callers, and the 
`CreateTableParserTest` copies are not on current `dev`, so any test movement 
stays with #12327.
   
   On compatibility, keeping the existing MaxCompute and ClickHouse class names 
(including `ColumnInfo`) as small deprecated forwarding adapters sounds like a 
reasonable, conservative default. It still leaves a single scanner 
implementation, which is the goal of this issue. Whether those public classes 
are outside the compatibility contract, and when the adapters can be removed, 
can be settled separately as you suggest.
   
   Let's continue the detailed review in #13291. You mention the updated-head 
fork Build is still pending and that no live MaxCompute or full engine-job 
coverage is claimed, so please update the PR once the Build finishes.
   
   <!-- streview-comment:2416 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to