DanielLeens opened a new pull request, #13311:
URL: https://github.com/apache/seatunnel/pull/13311

   ### Purpose of this pull request
   
   This contribution to Apache SeaTunnel corrects Aerospike sink licensing and 
keeps GNU Crypto 2.0.1 outside the shaded connector JAR. The sink was 
introduced in #8821. The 3.1.0 Maven Central connector contains all 453 GNU 
Crypto classes, and the source `NOTICE` incorrectly describes the Aerospike 
Java client as AGPL-licensed. The Aerospike Java client 4.4.17 is Apache-2.0 
and uses GNU Crypto for RIPEMD-160 and Base64. The source distribution contains 
dependency declarations rather than these libraries.
   
   The shade exclusion leaves GNU Crypto as a separate dependency in the 
reduced Maven POM. The patch removes the incorrect source `NOTICE` entry, adds 
artifact-specific license files, and documents the runtime download and 
corresponding sources. Keeping GNU Crypto external avoids shipping it in the 
aggregate JAR and preserves the existing client and key digest implementation.
   
   Scope is limited to the Aerospike client and GNU Crypto packaging. 
Separately, the existing Fastjson2 2.0.33 dependency brings in 
`DoubleToDecimal` and `TLongIntHashMap`, whose exact source headers carry GPLv2 
with the Classpath exception and LGPL-2.1-or-later, respectively. The classes 
are unchanged by this patch and their distribution needs separate review.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Users installing or upgrading a standalone Aerospike connector JAR must 
install `gnu-crypto-2.0.1.jar` separately in 
`${SEATUNNEL_HOME}/plugins/Aerospike/lib/` on the submission host and workers. 
The plugin still bundles Aerospike Java client 4.4.17 and uses the same record 
keys and job configuration.
   
   ### How was this patch tested?
   
   - Built with JDK 11 using `./mvnw -B -o -nsu -pl 
seatunnel-connectors-v2/connector-aerospike -am -Dmaven.gitcommitid.skip=true 
-Dmaven.javadoc.skip=true spotless:apply verify` with 
`JAVA_TOOL_OPTIONS=-Djdk.attach.allowAttachSelf=true`. All 610 tests passed, 
including the four Aerospike factory tests.
   - Compared the built JAR with the 3.1.0 Maven Central artifact. The new JAR 
has no GNU Crypto entries, retains all 351 Aerospike client classes 
byte-for-byte and the same factory SPI, and contains the connector-specific 
license and notice. The reduced POM retains `org.gnu:gnu-crypto:2.0.1` as a 
separate dependency.
   - Compared 30 Aerospike key digests and a Base64 round trip using the 
published JAR and the rebuilt JAR with the separate GNU Crypto JAR. All values 
matched.
   - The Aerospike E2E test now loads the separate JAR into the engine and 
verifies that the sink updates a record seeded by another client at the same 
key. The local Zeta E2E command reached Testcontainers and is still downloading 
the pinned Aerospike 6.4 image.
   
   ### Check list
   
   * [x] License materials for the affected binary are updated. This PR adds no 
new dependency version or packaged JAR.
   * [x] Connector documentation is updated.
   * [x] Upgrade instructions are recorded in `incompatible-changes.md`.
   * [x] Existing Aerospike plugin registration, distribution registration, and 
CI scope were checked. The existing sink E2E exercises the separate dependency.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to