SEZ9 commented on issue #12809:
URL: https://github.com/apache/seatunnel/issues/12809#issuecomment-7025141542

   Thanks @niumy0701, the TextChunk link is what the first ask was after: 
#13270 is now recorded here as the TextChunk rewrite, covering 
`docs/en/transforms/text-chunk.md` and `docs/zh/transforms/text-chunk.md` as a 
documentation-only change against dev.
   
   Going by your update, these earlier asks are covered:
   
   - **PR link:** #13270 is posted in this thread.
   - **Verification source:** you state the options were verified against 
`TextChunkTransformConfig` and `TextChunkTransformFactory#optionRule()`.
   - **Validation semantics:** you state the multi-table options and the 
conditional `text_field` / `chunk_size` / `overlap_size` semantics are 
described identically in both languages.
   
   Your update also mentions a passing fork Build on the latest head (run 
44071152209) and four review rounds with feedback addressed. I have not checked 
either from this thread, so that assessment stays on the PR.
   
   Remaining asks:
   
   - **Key-column restrictions:** your update does not mention the restrictions 
on `output_field` / `chunk_index_field`. Please confirm that both languages 
describe them the same way.
   - **PR description:** please confirm that the description of #13270 itself 
names the config and factory classes the option table was verified against, so 
the reviewer can check both languages against the same rule.
   - **DataValidator:** please post that PR link here once it is submitted, 
name `DataValidatorTransformConfig` and 
`DataValidatorTransformFactory#optionRule()` in its description, and keep the 
`row_error_handle_way` multi-table description the same in both languages.
   
   Detailed review of the TextChunk content will continue on #13270.
   
   <!-- streview-comment:2469 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to