zhiliang-wu-cn commented on PR #13304: URL: https://github.com/apache/seatunnel/pull/13304#issuecomment-7033528378
Thanks for the detailed review! I have addressed all 4 issues: Issue 1 (Syntax error in MaxcomputeSourceFactoryTest): Restored the closing brace for assertInvalidEndpoint before the new test method and ran spotless:apply. Issue 2 (Preserve failure for missing tables): Added odpsTable.reload() in MaxcomputeUtil.hasPartition to explicitly verify table existence before checking partitions, and removed the broad NoSuchObjectException catch. If a table does not exist, a MaxcomputeConnectorException is thrown with table context even when schema bypasses catalog lookup. Suppression strictly applies to missing partitions on existing tables. Added unit tests for both missing partition and missing table scenarios. Issue 3 (Opt-in enumeration & option inheritance test coverage): Enumerator & Reader: Added testEnumeratorDiscoveryBehavior in MaxcomputeSourceSplitTest exercising default false (no hasPartition check), opted-in missing partition (suppression of download session), readable second table (session created and splits assigned), and explicit non-default schema. Added testReaderCompletionWhenNoSplitsAssigned verifying MaxcomputeSourceReader signals completion cleanly. Option Inheritance: Added testOptionInheritanceAndPerTableOverrideInSource testing global false with per-table true override, explicit false, and fallback inheritance (without modifying production code). Integration Coverage: Extended MaxComputeIT with testIgnoreMissingPartitionEnumeration and testMissingPartitionThrowsWhenNotIgnored to validate behavior against the MaxCompute testcontainer. Issue 4 (Document suppression boundary & behavioral contracts): Added concise Javadocs in SourceTableInfo.java and MaxcomputeUtil.java documenting: The partition-only suppression boundary (missing partitions are ignored; missing tables throw). Schema precedence (tablePath.getSchemaName() > default schema). When the flag is consumed during split enumeration. All tests and spotless checks have passed locally (./mvnw spotless:apply, ./mvnw test -pl :connector-maxcompute, and ./mvnw -q -DskipTests verify -pl :connector-maxcompute,:connector-maxcompute-e2e). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
