zhiliang-wu commented on PR #13300:
URL: https://github.com/apache/seatunnel/pull/13300#issuecomment-7036236323

   Thanks for the review. I have updated the branch to address the comments:
   1. **ODPS Authentication boundary (Issue 1)**: Added a focused unit test 
`testAklessAccountSignWithCredentialsProvider` in `MaxcomputeUtilTest` 
verifying that `AklessAccount` accepts the `AlibabaCloudCredentialsProvider` 
and signs ODPS requests with the expected `Authorization` and 
`authorization-sts-token` headers.
      *(Note: E2E test for the cloud-specific VPC STS endpoint is skipped as 
Alibaba Cloud VPC networks are not available in CI/emulator environments).*
   2. **Documentation (Issue 2)**: Added documentation in both English and 
Chinese source and sink docs (`docs/en` and `docs/zh`) describing 
`ALIBABA_CLOUD_VPC_ENDPOINT_ENABLED` and `ALIBABA_CLOUD_STS_REGION` 
configuration, and note that credentials refresh on demand via `AklessAccount`.
   3. **Builder-local configuration (Issue 3)**: Updated 
`testOIDCRoleArnCredentialProviderVpcEndpointResolution` to use builder-local 
`.enableVpc(...)` and `.stsRegionId(...)` instead of mutating global 
`AuthUtils`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to