DanielLeens commented on PR #13327: URL: https://github.com/apache/seatunnel/pull/13327#issuecomment-7037839299
Sorry for missing this in my earlier documentation review. +1 to @BryanOnKeys: MetadataUtil.java:115 calls row.getRowKind().shortString(), so the emitted values are `+I`, `-U`, `+U` and `-D`, rather than INSERT, UPDATE_BEFORE, UPDATE_AFTER and DELETE. The documentation should describe the emitted values and map each one to its meaning in both EN and ZH. This is a correction to my earlier assessment, not a newly introduced runtime defect. Please update the examples/description before merge. The green Build does not close that documentation mismatch. No metadata runtime change is needed for this fix. Checked unchanged head `0de6521514f2a7cfc22e836eb87b4f9654bbad58` against `dev`: compare `diverged`, ahead 1 / behind 11. This drift is recorded independently; it does not by itself request synchronization. This is a discussion/CI follow-up, not another full source review. No local build, test or runtime execution was performed. Daniel has READ repository permission; effective maintainer approval/dismissal remains a separate repository gate. Checked 2026-11-20T11:59:57.811808+00:00. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
