SEZ9 commented on PR #13005: URL: https://github.com/apache/seatunnel/pull/13005#issuecomment-7052712369
@goutamadwant thanks for the update. Rejecting duplicate JSON fields for single and bulk submissions before the job config is built, validating variable names by their parsed paths while keeping the original spelling for substitution, rejecting repeated `variables` parameters on the v1 endpoint, and omitting the raw query string from POST warnings together close the earlier input-boundary concern. No source blocker remains from the existing review. What is still open is CI on head `c5739355834cbe55b6863e9bc0bb94f6c63e34ee`: - Build run `44482229686` is now `failure`. - The Dependency licenses job `135530865953` ended in a 40-minute timeout while Maven was fetching Felix/Plexus plugin metadata; it did not report a new license mismatch. - Elasticsearch JDK 17 and HBase JDK 11 failed while bootstrapping MavenWrapperMain, and the other required lanes were cancelled. These look like artifact/bootstrap problems rather than evidence against the REST config-variable handling. Remaining asks: 1. Please complete the failed and cancelled lanes once artifact access is working. 2. Please do not modify unrelated dependencies to chase the timeout. Thanks also for your latest note that successful empty Pod logs are now normalized to empty text in polling and diagnostics, with the HTTP error policy and terminal state checks unchanged and an empty log no longer stopping diagnostics. Is that change already part of head `c5739355834cbe55b6863e9bc0bb94f6c63e34ee`, or is it in a newer push? If it is newer, CI will need to complete on that head as well. <!-- streview-comment:2493 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
