Updated Branches: refs/heads/master 626149e91 -> 14f10a14c
SENTRY-60: TestSolrAuthzBinding does not properly test negative cases (Gregory Chanan via Shreepadma Venugopalan) Project: http://git-wip-us.apache.org/repos/asf/incubator-sentry/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-sentry/commit/14f10a14 Tree: http://git-wip-us.apache.org/repos/asf/incubator-sentry/tree/14f10a14 Diff: http://git-wip-us.apache.org/repos/asf/incubator-sentry/diff/14f10a14 Branch: refs/heads/master Commit: 14f10a14c10f94de18c9fc90161d7c04d8a58ce6 Parents: 626149e Author: Shreepadma Venugopalan <shreepa...@apache.org> Authored: Tue Nov 5 17:19:27 2013 -0800 Committer: Shreepadma Venugopalan <shreepa...@apache.org> Committed: Tue Nov 5 17:19:27 2013 -0800 ---------------------------------------------------------------------- .../java/org/apache/sentry/binding/solr/TestSolrAuthzBinding.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-sentry/blob/14f10a14/sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrAuthzBinding.java ---------------------------------------------------------------------- diff --git a/sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrAuthzBinding.java b/sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrAuthzBinding.java index 0dc3da1..494a430 100644 --- a/sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrAuthzBinding.java +++ b/sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrAuthzBinding.java @@ -174,7 +174,7 @@ public class TestSolrAuthzBinding { private void expectAuthException(SolrAuthzBinding binding, Subject subject, Collection collection, EnumSet<SearchModelAction> action) throws Exception { try { - binding.authorizeCollection(new Subject("bogus"), infoCollection, querySet); + binding.authorizeCollection(subject, collection, action); Assert.fail("Expected SentrySolrAuthorizationException"); } catch(SentrySolrAuthorizationException e) { }
