[
https://issues.apache.org/jira/browse/SENTRY-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516115#comment-14516115
]
Colin Ma commented on SENTRY-699:
---------------------------------
+1, LGTM, and I also checked the source code for the other ThreadLocal, they
are all defined with static.
> Memory leak when running Sentry w/ HiveServer2
> ----------------------------------------------
>
> Key: SENTRY-699
> URL: https://issues.apache.org/jira/browse/SENTRY-699
> Project: Sentry
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Lenni Kuff
> Assignee: Prasad Mujumdar
> Attachments: SENTRY-699.1.patch
>
>
> Each time a query executes we create a new instance of HiveAuthzConf which in
> turn creates a ResourceAuthorizationProvider. Within
> ResourceAuthorizationProvider there is a thread local variable:
> "ThreadLocal<List<String>> lastFailedPrivileges" which is not getting garbage
> collected since the parent thread is still alive. Over time, this leads to a
> memory leak in HS2. We need to be sure that any ThreadLocal state is cleaned
> up when we are done using it (or consider avoiding the use of ThreadLocal if
> possible).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
