[
https://issues.apache.org/jira/browse/SENTRY-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907680#comment-14907680
]
Hadoop QA commented on SENTRY-902:
----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12762328/SENTRY-902.2.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} failed to apply patch (exit code 1):
The patch does not appear to apply with p0, p1, or p2
Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/873/console
This message is automatically generated.
> SimpleDBProviderBackend should retry the authrization process properly
> ----------------------------------------------------------------------
>
> Key: SENTRY-902
> URL: https://issues.apache.org/jira/browse/SENTRY-902
> Project: Sentry
> Issue Type: Bug
> Affects Versions: 1.4.0
> Reporter: Yibing Shi
> Attachments: SENTRY-902.1.patch, SENTRY-902.2.patch
>
>
> Currently {{SimpleDBProviderBackend}} doesn't retry the authorization
> properly. Problems are:
> # It retry count is hard coded. Always retries once
> # No wait time between before retries
> # The method calls itself recursively, which could causes stack overflow if
> retries too many times
> # If an exception happens in
> {{SentryPolicyServiceClient.listPrivilegesForProvider}}, then
> {{policyServiceClient}} won't be closed, which could cause resource leak.
> Related codes are:
> https://github.com/cloudera/sentry/blob/cdh5-1.4.0_5.4.7/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SimpleDBProviderBackend.java#L75-L105
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
