[
https://issues.apache.org/jira/browse/SENTRY-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984705#comment-14984705
]
Yibing Shi commented on SENTRY-902:
-----------------------------------
[~colinma], the patch works for me:
{noformat}
➜ incubator-sentry git:(master) bash ./dev-support/smart-apply-patch.sh
~/Downloads/SENTRY-902.7.patch
Going to apply patch with: patch -p1
patching file
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SimpleDBProviderBackend.java
patching file
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
➜ incubator-sentry git:(master) ✗ git version
git version 2.5.2
➜ incubator-sentry git:(master) ✗
{noformat}
And Jenkins building output, I can find below:
{noformat}
INFO: Executing bash ./dev-support/smart-apply-patch.sh
/home/jenkins/jenkins-slave/workspace/PreCommit-SENTRY-Build/test-output/SENTRY-902.patch
1>/home/jenkins/jenkins-slave/workspace/PreCommit-SENTRY-Build/test-output/apply.txt
2>&1
The patch does not appear to apply with p0, p1, or p2
{noformat}
Is it trying to test {{SENTRY-902.patch}} or {{SENTRY-902.7.patch}}?
> SimpleDBProviderBackend should retry the authrization process properly
> ----------------------------------------------------------------------
>
> Key: SENTRY-902
> URL: https://issues.apache.org/jira/browse/SENTRY-902
> Project: Sentry
> Issue Type: Bug
> Affects Versions: 1.4.0
> Reporter: Yibing Shi
> Assignee: Yibing Shi
> Attachments: SENTRY-902.1.patch, SENTRY-902.2.patch,
> SENTRY-902.3.patch, SENTRY-902.4.patch, SENTRY-902.5.patch,
> SENTRY-902.6.patch, SENTRY-902.7.patch
>
>
> Currently {{SimpleDBProviderBackend}} doesn't retry the authorization
> properly. Problems are:
> # It retry count is hard coded. Always retries once
> # No wait time between before retries
> # The method calls itself recursively, which could causes stack overflow if
> retries too many times
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
