[
https://issues.apache.org/jira/browse/SENTRY-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013574#comment-15013574
]
Hadoop QA commented on SENTRY-966:
----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12773234/SENTRY-966.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/984/console
This message is automatically generated.
> SqoopAuthBindingSingleton uses bad double check locking idiom
> -------------------------------------------------------------
>
> Key: SENTRY-966
> URL: https://issues.apache.org/jira/browse/SENTRY-966
> Project: Sentry
> Issue Type: Bug
> Components: Sqoop plugin
> Reporter: Colm O hEigeartaigh
> Fix For: 1.7.0
>
> Attachments: SENTRY-966.patch
>
>
> The SqoopAuthBindingSingleton uses the bad double check locking idiom:
> http://www.javaworld.com/article/2074979/java-concurrency/double-checked-locking--clever--but-broken.html
> An easy solution is just to make the variable volatile, but a much better
> approach is to use the Lazy init holder class idiom, which avoid
> synchronization altogether.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
