Colm O hEigeartaigh created SENTRY-967:
------------------------------------------

             Summary: Use the Maven Dependency Plugin to download artifacts for 
the Sqoop tests
                 Key: SENTRY-967
                 URL: https://issues.apache.org/jira/browse/SENTRY-967
             Project: Sentry
          Issue Type: Improvement
          Components: Test
            Reporter: Colm O hEigeartaigh
            Priority: Trivial
             Fix For: 1.7.0



Currently the Maven antrun plugin is used to download a copy of Tomcat (6) and 
the Sqoop server to a "thirdparty" directory in the 
"sentry-tests/sentry-tests-sqoop" directory.

However there are a number of problems with this approach:

a) You are not downloading to a temporary directory (I guess to save having to 
download the artifacts on every build). This is not good practice, as a "mvn 
clean" doesn't actually clean this directory
b) If the download is corrupted, the corrupted artifact will stay in 
"thirdparty", as the directory is not removed as part of the build process.
c) The antrun/bash approach means that bash must be installed on the machine, 
which might be problematic (e.g. on windows)

A better approach is to use the Maven dependency plugin to download the 
artifacts and copy them to a directory in the "target" directory of the tests. 
The artifacts get downloaded to the local maven repository, so after the first 
download, the build won't have to redownload anything. It should work on every 
platform as well.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to