[
https://issues.apache.org/jira/browse/SENTRY-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124077#comment-15124077
]
Sravya Tirukkovalur commented on SENTRY-1032:
---------------------------------------------
Theroritically I do not see a difference between "adding a group to a role"
versus "adding a role to a group". But from a user stand point groups come
first and they grant roles to groups. So adding roles to groups make more
sense. Also, all our client apis use addRoleToGroups deleteRoleFromGroups
https://github.com/apache/incubator-sentry/blob/95b1e40e7062343f05e131afaea0a97bbf71ba4f/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClient.java#L63
So I think it makes sense to stick with --add-role-group, or may be make it
--grant-role-to-group to keep it consistent with the beeline shell?
> Rename shell command group/role shell commands and implement with solr shell
> ----------------------------------------------------------------------------
>
> Key: SENTRY-1032
> URL: https://issues.apache.org/jira/browse/SENTRY-1032
> Project: Sentry
> Issue Type: Task
> Components: Service
> Affects Versions: 1.7.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Attachments: SENTRY-1032.patch
>
>
> --add_role_group is a bit confusing because the command is to add group to
> role (i.e. the objects are reversed). Let's change this before it is
> released and we need to support backwards compatibility.
> same for --delete_role_group.
> Also, these commands are not implemented with SentryShellSolr. Let's do that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
