zhengyangyong commented on a change in pull request #47: General development
dir translation and include img
URL:
https://github.com/apache/incubator-servicecomb-docs/pull/47#discussion_r216601228
##########
File path:
java-chassis-reference/en_US/general-development/report-framework-version.md
##########
@@ -1,59 +1,54 @@
-## 概念阐述
+## Concept Description
-为方便治理，使用ServiceComb进行开发，会将当前使用的ServiceComb版本号上报至服务中心，并且支持其他框架集成ServiceComb时上报其他框架的版本号。
+To facilitate the management, using ServiceComb for development, the currently
used ServiceComb version number will be reported to the service center, and the
version number of other frameworks will be reported when other frameworks
integrate ServiceComb.
-## 示例代码
+## Sample Code
-步骤1 首先实现开源框架ServiceComb的Versions接口，实现该接口下的loadVersion方法，即可将版本名称和版本号作为键值对返回
+Step 1 First, implement the Versions interface of the open source framework
ServiceComb, implement the loadVersion method under the interface, and return
the version name and version number as key-value pairs.
```
public class MyVersion implements Versions{
- @Override
- public Map<String, String> loadVersion() {
- Map<String, String> map = new HashMap<>();
- map.put("My", this.getClass().getPackage().getImplementationVersion());
- return map;
- }
+ @override
Review comment:
@override 的O还是要大写
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
