liubao68 commented on a change in pull request #1017: [SCB-1056] put provider
flow control logic in front
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1017#discussion_r238061857
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
##########
@@ -150,6 +167,39 @@ protected void scheduleInvocation() {
});
}
+ private Holder<Boolean> checkQpsFlowControl(OperationMeta operationMeta) {
+ Holder<Boolean> qpsFlowControlReject = new Holder<>(false);
+ Handler providerQpsFlowControlHandler =
findQpsFlowControlHandler(operationMeta);
+ if (null != providerQpsFlowControlHandler) {
+ try {
+ providerQpsFlowControlHandler.handle(invocation, response -> {
Review comment:
I got it. Do you think it's better to give an option to turn on
ProviderQpsFlowControlHandler in AbstractRestInvocation, and do not change the
execution flow of handler? That is, when users do want
ProviderQpsFlowControlHandler executed in AbstractRestInvocation, they must
configure option to true, and remove handler configuration in chain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
