WillemJiang commented on a change in pull request #513: [SCB-1391] Add support
for explicit tx context passing for TCC
URL: https://github.com/apache/servicecomb-pack/pull/513#discussion_r307078714
##########
File path:
omega/omega-transaction/src/main/java/org/apache/servicecomb/pack/omega/transaction/TransactionContextUtils.java
##########
@@ -0,0 +1,40 @@
+package org.apache.servicecomb.pack.omega.transaction;
+
+import org.apache.servicecomb.pack.omega.context.OmegaContext;
+import org.apache.servicecomb.pack.omega.context.TransactionContext;
+import org.apache.servicecomb.pack.omega.context.TransactionContextProperties;
+import org.slf4j.Logger;
+
+public abstract class TransactionContextUtils {
Review comment:
Static method is hard for extension, my suggestion is letting the
TransactionAspect, TccParticipatorAspect extends the class of
TransactionContextHelper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
