WillemJiang commented on a change in pull request #9: SCB-1383 support toolkit
maven plugin commands that generating code
URL: https://github.com/apache/servicecomb-toolkit/pull/9#discussion_r307572736
##########
File path:
toolkit-maven-plugin/src/main/java/org/apache/servicecomb/toolkit/plugin/GenerateUtil.java
##########
@@ -81,10 +83,55 @@ public FileVisitResult visitFile(Path file,
BasicFileAttributes attrs) throws IO
.substring(0, file.toFile().getName().indexOf(".")));
docGenerator.configure(docGeneratorConfig);
- docGenerator.generate();
+ if (!docGenerator.generate()) {
+ throw new RuntimeException("failed to generate document by generator
" + type);
Review comment:
Can we add more specific information here?
You can just throw the exception with detail information inside of generate
method of docGenerator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
