liubao68 commented on a change in pull request #1355: [SCB-1489] Use old
instanceId to re-register instance to service center
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1355#discussion_r337342820
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceRegisterTask.java
##########
@@ -103,9 +103,6 @@ protected boolean doRegister() {
return false;
}
- // In re-register microservice case, the old instanceId should not be
cached
- microservice.getInstance().setInstanceId(null);
-
LOGGER.info(
Review comment:
Maybe we need to set instance id to null when service id is empty. (When we
delete all information in service center, both the service and instance is a
new one.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
