coolbeevip commented on a change in pull request #609: WIP [SCB-1627] Omega side CallbackContext send the compensation result event to Alpha URL: https://github.com/apache/servicecomb-pack/pull/609#discussion_r352437366
########## File path: omega/omega-transaction/src/main/java/org/apache/servicecomb/pack/omega/transaction/CallbackContext.java ########## @@ -15,13 +15,14 @@ * limitations under the License. */ -package org.apache.servicecomb.pack.omega.context; Review comment: > We need to add a old class with deprecated annotation in org.apache.servicecomb.pack.omega.context to provide backward compatible support. This is a good idea otherwise I will modify a lot of tests cases（Although it has been modified a lot 😢） I think this feature only needs to support the SAGA state machine. For this, We need to add a parameter `alpha.feature.akka.transactions = saga, tcc` Currently, this feature is enabled with the following two parameters: ``` alpha.feature.akka.transactions=saga alpha.feature.akka.enabled=true ``` What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
