WillemJiang commented on a change in pull request #609: [SCB-1627] Omega side CallbackContext send the compensation result event to Alpha URL: https://github.com/apache/servicecomb-pack/pull/609#discussion_r355085924
########## File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/pack/alpha/core/OmegaCallback.java ########## @@ -17,9 +17,18 @@ package org.apache.servicecomb.pack.alpha.core; +import org.apache.servicecomb.pack.alpha.core.fsm.CompensateAckType; + public interface OmegaCallback { void compensate(TxEvent event); default void disconnect() { } + + default void ask(CompensateAckType type) { Review comment: I think the method name should be getAck. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services