chanjarster commented on a change in pull request #72: [SCB-1673] parse the
remaining information of RequestMapping
URL: https://github.com/apache/servicecomb-toolkit/pull/72#discussion_r361403724
##########
File path:
oas-generator/oas-generator-spring/src/test/java/org/apache/servicecomb/toolkit/generator/SpringAnnotationProcessorTest.java
##########
@@ -55,13 +57,15 @@
@Test
public void getHttpMethod() throws NoSuchMethodException {
Review comment:
This test is too big. Write individual method for each `@RequestMapping`
property and a test for properties inheritance, eg, Class level
`@RequestMapping` + Method level `RequestMapping`, will be clearer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
