tianxiaoliang commented on a change in pull request #90: #79 record polling
history
URL: https://github.com/apache/servicecomb-kie/pull/90#discussion_r377981851
##########
File path: server/resource/v1/kv_resource.go
##########
@@ -130,9 +137,11 @@ func (r *KVResource) List(rctx *restful.Context) {
returnData(rctx, domain, project, labels, limit, offset)
}
+//
func returnData(rctx *restful.Context, domain interface{}, project string,
labels map[string]string, limit, offset int64) {
revStr := rctx.ReadQueryParameter(common.QueryParamRev)
wait := rctx.ReadQueryParameter(common.QueryParamWait)
+ go RecordPollingDetail(rctx, revStr, wait, domain.(string), project,
labels, limit, offset)
Review comment:
不能够这么搞，应该在handler里根据url和method判断是polling动作就进分支记录polling信息
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
