tianxiaoliang commented on a change in pull request #108: #109
client支持指定revision
URL: https://github.com/apache/servicecomb-kie/pull/108#discussion_r386241330
##########
File path: client/client.go
##########
@@ -158,31 +161,39 @@ func (c *Client) Get(ctx context.Context, opts
...GetOption) (*model.KVResponse,
h := http.Header{}
resp, err := c.c.Do(ctx, http.MethodGet, url, h, nil)
if err != nil {
- return nil, err
+ return nil, -1, err
+ }
+ responseRevision, errRevision :=
strconv.Atoi(resp.Header.Get(common.HeaderRevision))
Review comment:
errRevision 没必要，用err就好了吧？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
