yeyiwei commented on a change in pull request #824:
URL: 
https://github.com/apache/servicecomb-service-center/pull/824#discussion_r555546642



##########
File path: datasource/etcd/ms.go
##########
@@ -751,39 +747,39 @@ func (ds *DataSource) GetInstances(ctx context.Context, 
request *pb.GetInstances
        var err error
        if len(request.ConsumerServiceId) > 0 {
                service, err = serviceUtil.GetService(ctx, domainProject, 
request.ConsumerServiceId)
-               if err != nil {
-                       log.Errorf(err, "get consumer failed, consumer[%s] find 
provider instances",
-                               request.ConsumerServiceId, 
request.ProviderServiceId)
-                       return &pb.GetInstancesResponse{
-                               Response: pb.CreateResponse(pb.ErrInternal, 
err.Error()),
-                       }, err
-               }
-               if service == nil {
-                       log.Errorf(nil, "consumer does not exist, consumer[%s] 
find provider instances",
-                               request.ConsumerServiceId, 
request.ProviderServiceId)
+               if errors.Is(err, datasource.ErrNoDocuments) {
+                       log.Error(fmt.Sprintf("consumer does not exist, 
consumer[%s] find provider[%s] instances",

Review comment:
       已按具体场景修改日志级别




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to