liubao68 commented on a change in pull request #2192:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/2192#discussion_r556206147
##########
File path:
handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestWeightedResponseTimeRuleExt.java
##########
@@ -73,10 +73,12 @@ public void testWeighed() {
} else {
server2.incrementAndGet();
}
+ //此处是为了控制请求的时间窗口大小，使得策略中1分钟大小的时间窗口生效，并产生变化
+ Thread.sleep(1);
Review comment:
1. How about not adding this ? Can this test case pass?
2. Maybe it's better after this test case passed, and wait 1 secondes, and
run the choose again, will give a distribution equal to 50%
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
