tianxiaoliang commented on a change in pull request #912:
URL: 
https://github.com/apache/servicecomb-service-center/pull/912#discussion_r599548459



##########
File path: datasource/mongo/ms.go
##########
@@ -59,7 +60,20 @@ func (ds *DataSource) RegisterService(ctx context.Context, 
request *discovery.Cr
        project := util.ParseProject(ctx)
        serviceFlag := util.StringJoin([]string{
                service.Environment, service.AppId, service.ServiceName, 
service.Version}, "/")
-       //todo add quota check
+       domainProject := util.ParseDomainProject(ctx)

Review comment:
       
这个service和instance的配额检查都应该在resource层检查,而不是ds层,etcd的实现也该被删除,由resource统一做,因此UT也要做些调整




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to