[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #911: [SCB-2094]restructure cache

[GitBox]

tianxiaoliang commented on a change in pull request #911:
URL: 
https://github.com/apache/servicecomb-service-center/pull/911#discussion_r608387609



##########
File path: datasource/mongo/event/instance_event_handler_test.go
##########
@@ -118,7 +117,6 @@ func mongoEventWronServiceId() sd.MongoEvent {
        mongoEvent.DocumentID = "5fdc483b4a885f69317e3505"
        mongoEvent.Value = mongoInstance
        mongoEvent.Type = discovery.EVT_CREATE
-       mongoEvent.ResourceID = "f73dceb440f711eba63ffa163e7cdcb8"

Review comment:
       为何删了

##########
File path: datasource/mongo/ms.go
##########
@@ -2591,49 +2590,6 @@ func allowAcrossDimension(ctx context.Context, 
providerService *model.Service, c
        return nil
 }
 
-func GetServiceByID(ctx context.Context, serviceID string) (*model.Service, 
error) {
-       cacheService, ok := 
sd.Store().Service().Cache().Get(serviceID).(model.Service)

Review comment:
       这一层才该依赖cache层




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org