tianxiaoliang commented on a change in pull request #953:
URL:
https://github.com/apache/servicecomb-service-center/pull/953#discussion_r620793955
##########
File path: datasource/mongo/ms.go
##########
@@ -1404,13 +1404,79 @@ func getServiceDetailUtil(ctx context.Context, mgs
*model.Service, countOnly boo
}
// Instance management
-func (ds *DataSource) RegisterInstance(ctx context.Context, request
*discovery.RegisterInstanceRequest) (*discovery.RegisterInstanceResponse,
error) {
+func (ds *DataSource) RegisterInstance(ctx context.Context,
+ request *discovery.RegisterInstanceRequest)
(*discovery.RegisterInstanceResponse, error) {
+
+ isCustomID := true
Review comment:
为何要做这种判断，id有就是custom了，直接透传覆盖就行了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
