Shoothzj commented on a change in pull request #2628:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/2628#discussion_r739619280
##########
File path:
transports/transport-rest/transport-rest-vertx/src/test/java/org/apache/servicecomb/transport/rest/vertx/TestTransportConfig.java
##########
@@ -63,174 +67,252 @@ int availableProcessors() {
@Test
public void testGetThreadCountNormal() {
- ArchaiusUtils.setProperty("servicecomb.rest.server.thread-count", 10);
- Assert.assertEquals(10, TransportConfig.getThreadCount());
+ try {
+ ArchaiusUtils.setProperty("servicecomb.rest.server.thread-count", 10);
+ Assert.assertEquals(10, TransportConfig.getThreadCount());
+ } finally {
+ ArchaiusUtils.setProperty("servicecomb.rest.server.thread-count", null);
+ }
Review comment:
I don't know this method. You mean all our tests don't rely on `config`.
They can be cleared?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
