tianxiaoliang commented on a change in pull request #1169:
URL:
https://github.com/apache/servicecomb-service-center/pull/1169#discussion_r767360822
##########
File path: server/resource/disco/schema_resource.go
##########
@@ -115,26 +118,29 @@ func (s *SchemaService) ModifySchemas(w
http.ResponseWriter, r *http.Request) {
return
}
request.ServiceId = serviceID
- resp, err := core.ServiceAPI.ModifySchemas(r.Context(), request)
- if err != nil {
- log.Error("can not update schema", err)
- rest.WriteError(w, pb.ErrInternal, "can not update schema")
+ _, svcErr := discosvc.PutSchemas(r.Context(), request)
+ if svcErr != nil {
+ rest.WriteServiceError(w, svcErr)
Review comment:
错误日志
##########
File path: server/resource/disco/schema_resource.go
##########
@@ -115,26 +118,29 @@ func (s *SchemaService) ModifySchemas(w
http.ResponseWriter, r *http.Request) {
return
}
request.ServiceId = serviceID
- resp, err := core.ServiceAPI.ModifySchemas(r.Context(), request)
- if err != nil {
- log.Error("can not update schema", err)
- rest.WriteError(w, pb.ErrInternal, "can not update schema")
+ _, svcErr := discosvc.PutSchemas(r.Context(), request)
+ if svcErr != nil {
+ rest.WriteServiceError(w, svcErr)
return
}
- rest.WriteResponse(w, r, resp.Response, nil)
+ rest.WriteResponse(w, r, nil, nil)
}
-func (s *SchemaService) DeleteSchemas(w http.ResponseWriter, r *http.Request) {
+func (s *SchemaResource) DeleteSchema(w http.ResponseWriter, r *http.Request) {
query := r.URL.Query()
request := &pb.DeleteSchemaRequest{
ServiceId: query.Get(":serviceId"),
SchemaId: query.Get(":schemaId"),
}
- resp, _ := core.ServiceAPI.DeleteSchema(r.Context(), request)
- rest.WriteResponse(w, r, resp.Response, nil)
+ _, err := discosvc.DeleteSchema(r.Context(), request)
+ if err != nil {
+ rest.WriteServiceError(w, err)
Review comment:
错误日志
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
