This is an automated email from the ASF dual-hosted git repository.
liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git
The following commit(s) were added to refs/heads/master by this push:
new 089d13ddb [SCB-2471] optimize the compareTo(···) method (#2807)
089d13ddb is described below
commit 089d13ddb8277c70a309780bef3b6a7e38f0d0ec
Author: david6969xin <[email protected]>
AuthorDate: Wed May 4 09:49:54 2022 +0800
[SCB-2471] optimize the compareTo(···) method (#2807)
---
.../org/apache/servicecomb/darklaunch/oper/AbstractCondition.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/huawei-cloud/darklaunch/src/main/java/org/apache/servicecomb/darklaunch/oper/AbstractCondition.java
b/huawei-cloud/darklaunch/src/main/java/org/apache/servicecomb/darklaunch/oper/AbstractCondition.java
index cc8084fa8..e257aa763 100644
---
a/huawei-cloud/darklaunch/src/main/java/org/apache/servicecomb/darklaunch/oper/AbstractCondition.java
+++
b/huawei-cloud/darklaunch/src/main/java/org/apache/servicecomb/darklaunch/oper/AbstractCondition.java
@@ -67,16 +67,16 @@ public abstract class AbstractCondition implements
Condition {
public static int compareNum(Object num, String anotherNum) {
try {
if (num instanceof Integer) {
- return ((Integer) num).compareTo(Integer.valueOf(anotherNum));
+ return Integer.compare((Integer) num, Integer.parseInt(anotherNum));
}
if (num instanceof Long) {
- return ((Long) num).compareTo(Long.valueOf(anotherNum));
+ return Long.compare((Long) num, Long.parseLong(anotherNum));
}
if (num instanceof Double) {
- return ((Double) num).compareTo(Double.valueOf(anotherNum));
+ return Double.compare((Double) num, Double.parseDouble(anotherNum));
}
if (num instanceof Float) {
- return ((Float) num).compareTo(Float.valueOf(anotherNum));
+ return Float.compare((Float) num, Float.parseFloat(anotherNum));
}
} catch (NumberFormatException e) {
return 1;
